Review Request 118539: I needed this patch in order to succesfully compile a 20140603 git snapshot of plasma-desktop on top of KDE Frameworks 4.100.0

[Eric Hameleers]

> On June 4, 2014, 8:28 p.m., Marco Martin wrote:
> > what is the stuff that still needs kdelibs4support? it shouldn't depend on it anymore

Files in the subdirectories of kcms/kfintinst/ contain includes for stuff that I can only find in kdelibs4support. Like "#include <KGlobal>" in kcms/kfontinst/lib/FcEngine.cpp to give one example. SInce all it complains about is the includes, perhaps those can be removed without harm... I don't know and I did not try, I am not a developer but a packager.

If I don't apply the patch (just tried) the build fails here at first (and if you gradually apply all the parts of the patch the build will fail in other directories) because of a missing include:

[ 77%] Automoc for target kfontinst
[ 77%] Built target kfontinst_automoc
[ 79%] Built target kfontinst
[ 79%] Automoc for target kfontinstui
[ 79%] Built target kfontinstui_automoc
[ 79%] Building CXX object kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o
In file included from /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.h:32:0,
                 from /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.cpp:24:
/mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/KfiConstants.h:28:28: fatal error: KLocalizedString: No such file or directory
 #include <KLocalizedString>
                            ^
compilation terminated.
make[2]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o] Error 1
make[1]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/all] Error 2
make: *** [all] Error 2
plasma:plasma-desktop failed to build.


- Eric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118539/#review59240
-----------------------------------------------------------


On June 4, 2014, 7:42 p.m., Eric Hameleers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118539/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 7:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I needed this patch in order to succesfully compile a 20140603 git snapshot of plasma-desktop on top of KDE Frameworks 4.100.0
> 
> 
> Diffs
> -----
> 
>   kcms/kfontinst/apps/CMakeLists.txt d166d8a 
>   kcms/kfontinst/dbus/CMakeLists.txt 5e203eb 
>   kcms/kfontinst/kcmfontinst/CMakeLists.txt fe3d2cf 
>   kcms/kfontinst/kio/CMakeLists.txt 90c6e4d 
>   kcms/kfontinst/lib/CMakeLists.txt 799707d 
>   kcms/kfontinst/thumbnail/CMakeLists.txt e19385c 
>   kcms/kfontinst/viewpart/CMakeLists.txt f79d7a6 
> 
> Diff: https://git.reviewboard.kde.org/r/118539/diff/
> 
> 
> Testing
> -------
> 
> On Slackware-current x86_64
> 
> 
> Thanks,
> 
> Eric Hameleers
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140604/83eaa077/attachment.html>