<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118539/">https://git.reviewboard.kde.org/r/118539/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 4th, 2014, 8:28 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what is the stuff that still needs kdelibs4support? it shouldn't depend on it anymore</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Files in the subdirectories of kcms/kfintinst/ contain includes for stuff that I can only find in kdelibs4support. Like "#include <KGlobal>" in kcms/kfontinst/lib/FcEngine.cpp to give one example. SInce all it complains about is the includes, perhaps those can be removed without harm... I don't know and I did not try, I am not a developer but a packager.
If I don't apply the patch (just tried) the build fails here at first (and if you gradually apply all the parts of the patch the build will fail in other directories) because of a missing include:
[ 77%] Automoc for target kfontinst
[ 77%] Built target kfontinst_automoc
[ 79%] Built target kfontinst
[ 79%] Automoc for target kfontinstui
[ 79%] Built target kfontinstui_automoc
[ 79%] Building CXX object kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o
In file included from /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.h:32:0,
from /mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/FcEngine.cpp:24:
/mnt/hd/kde-build/plasma/plasma-desktop-20140604git/kcms/kfontinst/lib/KfiConstants.h:28:28: fatal error: KLocalizedString: No such file or directory
#include <KLocalizedString>
^
compilation terminated.
make[2]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/FcEngine.cpp.o] Error 1
make[1]: *** [kcms/kfontinst/lib/CMakeFiles/kfontinstui.dir/all] Error 2
make: *** [all] Error 2
plasma:plasma-desktop failed to build.
</pre>
<br />
<p>- Eric</p>
<br />
<p>On June 4th, 2014, 7:42 p.m. UTC, Eric Hameleers wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Eric Hameleers.</div>
<p style="color: grey;"><i>Updated June 4, 2014, 7:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I needed this patch in order to succesfully compile a 20140603 git snapshot of plasma-desktop on top of KDE Frameworks 4.100.0</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On Slackware-current x86_64</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/kfontinst/apps/CMakeLists.txt <span style="color: grey">(d166d8a)</span></li>
<li>kcms/kfontinst/dbus/CMakeLists.txt <span style="color: grey">(5e203eb)</span></li>
<li>kcms/kfontinst/kcmfontinst/CMakeLists.txt <span style="color: grey">(fe3d2cf)</span></li>
<li>kcms/kfontinst/kio/CMakeLists.txt <span style="color: grey">(90c6e4d)</span></li>
<li>kcms/kfontinst/lib/CMakeLists.txt <span style="color: grey">(799707d)</span></li>
<li>kcms/kfontinst/thumbnail/CMakeLists.txt <span style="color: grey">(e19385c)</span></li>
<li>kcms/kfontinst/viewpart/CMakeLists.txt <span style="color: grey">(f79d7a6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118539/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>