Review Request 118487: fix type issue with qreal
Harald Sitter
sitter at kde.org
Tue Jun 3 01:48:00 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118487/
-----------------------------------------------------------
(Updated June 3, 2014, 1:48 a.m.)
Review request for Plasma.
Changes
-------
I'd consider the redundancy a boon really ;)
Repository: plasma-framework
Description
-------
floor() returns double, qreal is a typedef and could be float (for example), so running a qmax(qreal, floor) may cause build failures
Diffs (updated)
-----
src/declarativeimports/core/framesvgitem.cpp def17ea551340e952ce1a9c52d8e7df308b2b8f1
Diff: https://git.reviewboard.kde.org/r/118487/diff/
Testing
-------
Thanks,
Harald Sitter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140603/b86d6bb8/attachment.html>
More information about the Plasma-devel
mailing list