Review Request 118487: fix type issue with qreal

[Thomas Braxton]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118487/#review59023
-----------------------------------------------------------



src/declarativeimports/core/framesvgitem.cpp
<https://git.reviewboard.kde.org/r/118487/#comment41073>

    double
    
    and isn't this redundant since 1.0 is double unless cast to something else?


- Thomas Braxton


On June 3, 2014, 1:36 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118487/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 1:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> floor() returns double, qreal is a typedef and could be float (for example), so running a qmax(qreal, floor) may cause build failures
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/framesvgitem.cpp def17ea551340e952ce1a9c52d8e7df308b2b8f1 
> 
> Diff: https://git.reviewboard.kde.org/r/118487/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140603/dba204b3/attachment.html>