Review Request 119557: use kpluginselector for enabling runners
Marco Martin
notmart at gmail.com
Thu Jul 31 21:48:28 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119557/
-----------------------------------------------------------
(Updated July 31, 2014, 9:48 p.m.)
Review request for Plasma.
Repository: plasma-desktop
Description (updated)
-------
there is a standard widget to enable or disable plugins used around: kpluginselector.
this is needed also to access the about dialog of runners (maybe not 100% needed) and the config dialog some runners have (that's absolutely needed)
graphically looks similar, just a bit more detailed (displays comments from the metadata files as well)
note there is still a bug this uncovered before it can be merged (probably the reason it wasn't used before) the scrollbars are always hidden right now.
that's a problem in kcategorizedview due to a workaround of an old Qt4 bug
Diffs
-----
kcms/runners/kcm.h 0458430879964a10b2a15ff6660919874b7a5c3d
kcms/runners/kcm.cpp 0de07fbd73f692acb7b68efa665ba72dc8eddc5b
Diff: https://git.reviewboard.kde.org/r/119557/diff/
Testing
-------
File Attachments (updated)
----------------
snapshot4.png
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/be11d3fa-5de4-496b-a79e-450bd78318e6__snapshot4.png
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140731/68cf3498/attachment-0001.html>
More information about the Plasma-devel
mailing list