Review Request 119557: use kpluginselector for enabling runners

Marco Martin notmart at gmail.com
Thu Jul 31 21:47:02 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119557/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-desktop


Description
-------

there is a standard widget to enable or disable plugins used around: kpluginselector.
this is needed also to access the about dialog of runners (maybe not 100% needed) and the config dialog some runners have (that's absolutely needed)
graphically looks similar, just a bit more detailed (displays comments of the metadata files as well)

note there is still a bug this uncovered before it can be merged (probably the reason it wasn't used before) that is scrollbars never being visible.
that's a problem in kcategorizedview due to a workaround of an old qt4 bug


Diffs
-----

  kcms/runners/kcm.h 0458430879964a10b2a15ff6660919874b7a5c3d 
  kcms/runners/kcm.cpp 0de07fbd73f692acb7b68efa665ba72dc8eddc5b 

Diff: https://git.reviewboard.kde.org/r/119557/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140731/b5f14f65/attachment.html>


More information about the Plasma-devel mailing list