Review Request 119465: Have separate texture hashes for each window

[David Edmundson]

> On July 25, 2014, 3:43 p.m., Martin Gräßlin wrote:
> > The problem is not the different window, but probably the different OpenGL context. QtQuick uses with the threaded renderer an OpenGL context per QWindow. Marco could confirm that by enforcing the main thread renderer and verify that this also fixes the problem. If that's the case I'd rather go for verifying that it's the correct OpenGL context than the QWindow.
> 
> Marco Martin wrote:
>     yep, with export QSG_RENDER_LOOP=basic seems rendering is correct

I don't think comparing contexts is possible here.
Qt has a wrapper round the OpenGL context, QOpenGLContext.

You have one of those per window, even if underneath there is just one OpenGL context. It's possible to get the "shareContext" but according to the docs that can return 0 on some platforms at which point we're playing dangerously.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119465/#review63166
-----------------------------------------------------------


On July 25, 2014, 2:28 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119465/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 2:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Apparently in nvidia we get corruptions when a texture created for a window is used in another one.
> With this patch we tell the texture has changed when we move it from a window to another, so it's re-created and we keep textures for all windows separately. This way we ensure they don't mix.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/framesvgitem.h 0b39c70 
>   src/declarativeimports/core/framesvgitem.cpp ebac29f 
> 
> Diff: https://git.reviewboard.kde.org/r/119465/diff/
> 
> 
> Testing
> -------
> 
> Still works here, I hope Marco can confirm it fixes the problem.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140725/cce49cbf/attachment-0001.html>