Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES

[John Layt]

> On July 3, 2014, 12:41 p.m., Aleix Pol Gonzalez wrote:
> > Don't we still need to pass the language somehow? or now it will be enough with $LANG?
> 
> Vishesh Handa wrote:
>     KLocale languages had a list of languages. The first one being the main one, and others being fallbacks. We no longer seem to support this "multiple languages" option in QLocale.
>     
>     I'm not familiar with KSplash internals and why we ever needed to pass the languages variable at all.
> 
> Sebastian Kügler wrote:
>     We still support it, but it's now the $LANGUAGES variable (which in contrast to $LANG is a list of languages, preferred and fallback). In principle, this patch is fine, I'd go with "let's kill KLOCALE_LANG and see what breaks", but on RC-tagging-day, this might not be the most prudent thing to do.
>     
>     I'm also not familiar with KSplash, but with the current design we ship, there's nothing translated there, anyway, so it's not like we're breaking the default setup.
> 
> Vishesh Handa wrote:
>     So, I ship this tomorrow after the tagging?

A quick grep shows this is the *only* place that $KLOCALE_LANGUAGES gets used, and it gets unset immediately afterwards, so the entire process is redundant if KSPlash doesn't use it.  I don't know why KSplash needed it before, but now it could use $LANGUAGES instead, or QLocale().uiLanguages() after $LANGUAGES is set.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119103/#review61543
-----------------------------------------------------------


On July 3, 2014, 12:25 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119103/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 12:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
>     Startkde: Remove KLOCALE_LANGUAGES
> 
>     KLOCALE_LANGUAGES was used by the kde4 ksplash in order to to know which
>     language to show. This environment variable is no longer used by the qml
>     based ksplash. It makes no sense to have it.
> 
>     Additionally, this means we can stop linking against kdelibs4support.
>     This is important cause kdostartupconfig blocks the rest of the boot
>     sequence. On my system it causes a good 0.3 - 0.4 seconds delay. By no
>     longer linking to kdelibs4support it takes less than 0.1 seconds and no
>     longer shows up in the bootchat logs.
> 
> 
> Diffs
> -----
> 
>   startkde/kstartupconfig/CMakeLists.txt 6920fe5 
>   startkde/kstartupconfig/kdostartupconfig.cpp d545f4f 
>   startkde/startkde.cmake 40e3377 
> 
> Diff: https://git.reviewboard.kde.org/r/119103/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140703/37bc3d0f/attachment.html>