<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119103/">https://git.reviewboard.kde.org/r/119103/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 3rd, 2014, 12:41 p.m. BST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't we still need to pass the language somehow? or now it will be enough with $LANG?</pre>
</blockquote>
<p>On July 3rd, 2014, 1:46 p.m. BST, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KLocale languages had a list of languages. The first one being the main one, and others being fallbacks. We no longer seem to support this "multiple languages" option in QLocale.
I'm not familiar with KSplash internals and why we ever needed to pass the languages variable at all.</pre>
</blockquote>
<p>On July 3rd, 2014, 2:18 p.m. BST, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We still support it, but it's now the $LANGUAGES variable (which in contrast to $LANG is a list of languages, preferred and fallback). In principle, this patch is fine, I'd go with "let's kill KLOCALE_LANG and see what breaks", but on RC-tagging-day, this might not be the most prudent thing to do.
I'm also not familiar with KSplash, but with the current design we ship, there's nothing translated there, anyway, so it's not like we're breaking the default setup.</pre>
</blockquote>
<p>On July 3rd, 2014, 2:51 p.m. BST, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So, I ship this tomorrow after the tagging?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A quick grep shows this is the *only* place that $KLOCALE_LANGUAGES gets used, and it gets unset immediately afterwards, so the entire process is redundant if KSPlash doesn't use it. I don't know why KSplash needed it before, but now it could use $LANGUAGES instead, or QLocale().uiLanguages() after $LANGUAGES is set.</pre>
<br />
<p>- John</p>
<br />
<p>On July 3rd, 2014, 12:25 p.m. BST, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated July 3, 2014, 12:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Startkde: Remove KLOCALE_LANGUAGES
KLOCALE_LANGUAGES was used by the kde4 ksplash in order to to know which
language to show. This environment variable is no longer used by the qml
based ksplash. It makes no sense to have it.
Additionally, this means we can stop linking against kdelibs4support.
This is important cause kdostartupconfig blocks the rest of the boot
sequence. On my system it causes a good 0.3 - 0.4 seconds delay. By no
longer linking to kdelibs4support it takes less than 0.1 seconds and no
longer shows up in the bootchat logs.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startkde/kstartupconfig/CMakeLists.txt <span style="color: grey">(6920fe5)</span></li>
<li>startkde/kstartupconfig/kdostartupconfig.cpp <span style="color: grey">(d545f4f)</span></li>
<li>startkde/startkde.cmake <span style="color: grey">(40e3377)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119103/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>