Review Request 115192: Fix building 32bit target on 64bit machine

David Edmundson david at davidedmundson.co.uk
Thu Jan 30 14:36:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115192/#review48616
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Jan. 21, 2014, 6:42 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115192/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 6:42 p.m.)
> 
> 
> Review request for kdewin and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> with_SSE2_explicitly_enabled_if_x86 namespace is only implemented with THIS_PATH_WITH_SSE2_EXPLICTLY_ENABLED defined, this symbol is defined in render_with_SSE2_explicitly_enabled.cpp, but this source is only built when using a 32bit processor. In my case HAVE_PATH_WITH_SSE2_EXPLICITLY_ENABLED is defined, though, in global.h, since this is not a 64bit target.
> 
> 
> Diffs
> -----
> 
>   wallpapers/mandelbrot/renderthread.cpp c1b5c60 
> 
> Diff: https://git.reviewboard.kde.org/r/115192/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC 2010, 32bit target, with ${CMAKE_SYSTEM_PROCESSOR}=AMD64 (it's a x86_64 processor)
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140130/4d538ed3/attachment.html>


More information about the Plasma-devel mailing list