Review Request 115162: Launch single instance of plasma-mediacenter

[Sujith Haridasan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115162/
-----------------------------------------------------------

(Updated Jan. 22, 2014, 6:38 a.m.)


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Changes
-------

Modified the code to address the issues pointed out by Shantanu.


Repository: plasma-mediacenter


Description
-------

Launching single instance of plasma-mediacenter. Using KUniqueApplication only single instance of plasma-mediacenter is launched.


Diffs (updated)
-----

  shells/newshell/application.h PRE-CREATION 
  shells/newshell/application.cpp PRE-CREATION 
  shells/newshell/main.cpp 9fd5df3 
  shells/newshell/mainwindow.h 5e0753e 
  shells/newshell/mainwindow.cpp 1bf56ac 
  shells/newshell/plasma-mediacenter.desktop c3c5781 
  shells/newshell/CMakeLists.txt 60949df 

Diff: https://git.reviewboard.kde.org/r/115162/diff/


Testing
-------

Tests done using konsole:
a) Open a tab and launch pmc.
b) Open another tab and try to launch another instance of pmc.
c) After executing (b) pmc wont launch because already another instance of pmc from (a) is already running.

Tests done using Dolphin:
a) Go to the music folder and right click on the file to be played. Click open with and launch pmc.
b) Try to open another file using same step as (a)
c) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running.


Thanks,

Sujith Haridasan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140122/62d40331/attachment.html>