Review Request 115162: Launch single instance of plasma-mediacenter

[Sinny Kumari]

> On Jan. 21, 2014, 5:58 p.m., Shantanu Tushar wrote:
> > I couldn't try it right now but I have this doubt. If there is already a PMC instance running and open a file from Dolphin, does the file indeed start playing?
> 
> Sujith Haridasan wrote:
>     What I meant to say is if PMC is already running and if user tries to open a file from Dolphin then there will be only one instance running which will be the first running instance. And hence the file tried to open via Dolphin has no effect. So nothing happens to running instance.
> 
> Shantanu Tushar wrote:
>     Which is not what the user will expect, its expected that the file will start playing or will at least be added to the playlist.
> 
> Sujith Haridasan wrote:
>     This is the initial step. Once we achieve this here is the task break up:
>     
>     a) Clean up the playlist model code.
>     b) Address the issue of adding file(s) to playlist or start playing when tried to open from Dolphin or command line.

Sujith already informed me regarding his next task that he will re-factor Playlist code first and then he will add feature to play media opened through dolphin if PMC is already running.

If all steps are supposed to go together then this feature should be committed in a new branch and should e merged when it works perfectly.


- Sinny


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115162/#review47915
-----------------------------------------------------------


On Jan. 21, 2014, 6:44 a.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115162/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 6:44 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Launching single instance of plasma-mediacenter. Using KUniqueApplication only single instance of plasma-mediacenter is launched.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/CMakeLists.txt 60949df 
>   shells/newshell/application.h PRE-CREATION 
>   shells/newshell/application.cpp PRE-CREATION 
>   shells/newshell/main.cpp 9fd5df3 
>   shells/newshell/plasma-mediacenter.desktop c3c5781 
> 
> Diff: https://git.reviewboard.kde.org/r/115162/diff/
> 
> 
> Testing
> -------
> 
> Tests done using konsole:
> a) Open a tab and launch pmc.
> b) Open another tab and try to launch another instance of pmc.
> c) After executing (b) pmc wont launch because already another instance of pmc from (a) is already running.
> 
> Tests done using Dolphin:
> a) Go to the music folder and right click on the file to be played. Click open with and launch pmc.
> b) Try to open another file using same step as (a)
> c) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140122/ffc28441/attachment.html>