Crash in plasmapkg

[Marco Martin]

On Sat, Jan 11, 2014 at 6:14 PM, Bhushan Shah <bhush94 at gmail.com> wrote:

> Hello,
>
> I am getting crash in plasmapkg --list-types, I can not find required
> component on BKO so reporting it here.
>
> #0  Plasma::PlasmaPkgPrivate::renderTypeTable (this=0x8064d68,
> plugins=...) at
> /home/bshah/kdesrc/plasma-framework/src/plasmapkg/plasmapkg.cpp:488
> #1  0x08052370 in Plasma::PlasmaPkgPrivate::listTypes (this=0x8064d68)
> at /home/bshah/kdesrc/plasma-framework/src/plasmapkg/plasmapkg.cpp:560
>

hmm, the code at plasmapkg.cpp:488 seriously stinks:
if (pluginIt.value()[1].length() > paccessed as an arraythWidth) {
            pathWidth = pluginIt.value()[1].length();
        }

pluginIt.value() is a qstringList, so should never be accessed an array,
and from the code is not clear what it actually *is*

so, if i'm explained what the code is supposed to do, should be trivial to
fix (and make it a bit clearer)

--
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140113/1506438d/attachment.html>