Review Request 114818: battery monitor renaming to org.kde.plasma.battery

[Unicode Snowman]

Hi,

Sorry about that, would moving everything in
plasma/generic/applets/batterymonitor except CMakeLists.txt, and
battery-oxygen(-inkscape).svgz to a new directory, and then calling
plasma_install_package on the new directory work? Would that introduce
any conflicts?

Thanks,
Danny

On 1/3/14, Sebastian Kügler <sebas at kde.org> wrote:
> Hi Danny,
>
> On Friday, January 03, 2014 06:07:04 Danny Rim wrote:
>> https://git.reviewboard.kde.org/r/114818/
>
>> This change has been marked as submitted.
>>
>>
>> Review request for Plasma and Bhushan Shah.
>
>>   plasma/generic/applets/batterymonitor/metadata.desktop d84e25f
>>   plasma/generic/applets/batterymonitor/Messages.sh ea49cfd
>>   plasma/generic/applets/batterymonitor/CMakeLists.txt 0fdbbf9
>>
>> Diff: https://git.reviewboard.kde.org/r/114818/diff/
>
> The cmake logic here is not correct, two extraneous files are installed:
>
> /home/sebas/kf5/install/share/plasma/plasmoids/org.kde.plasma.battery/battery-
> oxygen.svgz
> /home/sebas/kf5/install/share/plasma/plasmoids/org.kde.plasma.battery/battery-
> oxygen-inkscape.svgz
>
> Please change the install commands so that these only end up being installed
>
> to the theme, but not to the plasmoid directory. You can compare with how
> it's
> originally done. Alternatively, file a review request to move these elements
>
> into the individual themes (though you'll need to check if the files exist
> in
> all themes, then).
>
> Cheers,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
>