Review Request 114818: battery monitor renaming to org.kde.plasma.battery

Bhushan Shah bhush94 at gmail.com
Fri Jan 3 11:10:54 UTC 2014


Hello!

On Fri, Jan 3, 2014 at 4:27 PM, Sebastian Kügler <sebas at kde.org> wrote:
> The cmake logic here is not correct, two extraneous files are installed:
>
>  /home/sebas/kf5/install/share/plasma/plasmoids/org.kde.plasma.battery/battery-
> oxygen.svgz
> /home/sebas/kf5/install/share/plasma/plasmoids/org.kde.plasma.battery/battery-
> oxygen-inkscape.svgz
>
> Please change the install commands so that these only end up being installed
> to the theme, but not to the plasmoid directory. You can compare with how it's
> originally done. Alternatively, file a review request to move these elements
> into the individual themes (though you'll need to check if the files exist in
> all themes, then).


I will fix it! :)

Thanks!

-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode


More information about the Plasma-devel mailing list