Review Request 115902: Force backgroundcontrast during slidingpopup animations

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115902/#review50363
-----------------------------------------------------------



kwin/effects/slidingpopups/slidingpopups.cpp
<https://git.reviewboard.kde.org/r/115902/#comment35427>

    please prefer the alpha check



kwin/effects/slidingpopups/slidingpopups.cpp
<https://git.reviewboard.kde.org/r/115902/#comment35428>

    i'll remind that this does not solve pot. races but relies on aligned runtimes.
    
    if the hint can expected to be set by different effects, you might still run into:
    "start short, start long, short exits, flicker" -> the hint should really be additive (in a second patch)


- Thomas Lübking


On Feb. 20, 2014, 1:11 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115902/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 1:11 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Force backgroundcontrast during slidingpopup animations
> 
> This fixes the sliding popups losing their contrast effect when
> animating, less flicker.
> 
> In this patch, we temporarily force the contrast effect on, but only if
> it hasn't been explicitely disabled. As soon as the animation stops, the
> force flag is disabled again. For disappearing windows, we just set the
> flag in the same way, but skip over the bookkeeping, since the window is
> going to be deleted, anyway.
> 
> 
> Diffs
> -----
> 
>   kwin/effects/slidingpopups/slidingpopups.h f66e42e 
>   kwin/effects/slidingpopups/slidingpopups.cpp 4f0a9ea 
> 
> Diff: https://git.reviewboard.kde.org/r/115902/diff/
> 
> 
> Testing
> -------
> 
> Slowed down effects, made sure the contrast effect is applied correctly, made sure the bookkeeping is OK. No visible side-effects observed.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140220/f0e0d2f4/attachment.html>