Review Request 115902: Force backgroundcontrast during slidingpopup animations

Sebastian Kügler sebas at
Thu Feb 20 13:11:14 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 20, 2014, 1:11 p.m.)


This change has been marked as submitted.

Review request for kwin and Plasma.

Repository: kde-workspace


Force backgroundcontrast during slidingpopup animations

This fixes the sliding popups losing their contrast effect when
animating, less flicker.

In this patch, we temporarily force the contrast effect on, but only if
it hasn't been explicitely disabled. As soon as the animation stops, the
force flag is disabled again. For disappearing windows, we just set the
flag in the same way, but skip over the bookkeeping, since the window is
going to be deleted, anyway.


  kwin/effects/slidingpopups/slidingpopups.h f66e42e 
  kwin/effects/slidingpopups/slidingpopups.cpp 4f0a9ea 



Slowed down effects, made sure the contrast effect is applied correctly, made sure the bookkeeping is OK. No visible side-effects observed.


Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Plasma-devel mailing list