Review Request 115902: Force backgroundcontrast during slidingpopup animations

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115902/
-----------------------------------------------------------

(Updated Feb. 20, 2014, 1:28 a.m.)


Review request for kwin and Plasma.


Changes
-------

const pointers in the list.


Repository: kde-workspace


Description
-------

Force backgroundcontrast during slidingpopup animations

This fixes the sliding popups losing their contrast effect when
animating, less flicker.

In this patch, we temporarily force the contrast effect on, but only if
it hasn't been explicitely disabled. As soon as the animation stops, the
force flag is disabled again. For disappearing windows, we just set the
flag in the same way, but skip over the bookkeeping, since the window is
going to be deleted, anyway.


Diffs (updated)
-----

  kwin/effects/slidingpopups/slidingpopups.h f66e42e 
  kwin/effects/slidingpopups/slidingpopups.cpp 4f0a9ea 

Diff: https://git.reviewboard.kde.org/r/115902/diff/


Testing
-------

Slowed down effects, made sure the contrast effect is applied correctly, made sure the bookkeeping is OK. No visible side-effects observed.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140220/d680cf85/attachment.html>