Review Request 115859: Force-allow background contrast while sliding desktops

[Sebastian Kügler]

> On Feb. 19, 2014, 6:35 a.m., Martin Gräßlin wrote:
> > kwin/effects/slide/slide.cpp, lines 241-245
> > <https://git.reviewboard.kde.org/r/115859/diff/7/?file=244900#file244900line241>
> >
> >     suggestion: loop over m_backgroundContrastForcedBefore - you are only operating on them and the set should be much smaller

The problem here is that we're caching pointers, and I'm not sure that every pointer in m_backgroundContrastForcedBefore is still valid, as there's zero bookkeeping for vanishing windows. This approach sounds rather a lot safer to me, stackingOrder() is something I can trust.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115859/#review50191
-----------------------------------------------------------


On Feb. 19, 2014, 12:37 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115859/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 12:37 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Force-allow background contrast while sliding
> 
> When the sliding effect is active, the background blur of the panel
> would be disabled unless forced with WindowForceBackgroundContrastRole,
> which is actually what we want: during sliding, the backgroundcontrast
> effect would otherwise be disabled, leading to the panel and popups
> flickering between contrast enabled and disabled.
> 
> With this patch, the panel keeps its coloring during desktop changes.
> 
> 
> Diffs
> -----
> 
>   kwin/effects/slide/slide.h c8e0a84 
>   kwin/effects/slide/slide.cpp 8ecb2a6 
> 
> Diff: https://git.reviewboard.kde.org/r/115859/diff/
> 
> 
> Testing
> -------
> 
> Switched desktops, panel keeps color, fullscreen video player doesn't seem to be affected negatively, everything still works as expected, except that the flickering in Plasma Dialogs is gone.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140219/e445ff5d/attachment.html>