Review Request 115859: Force-allow background contrast while sliding desktops

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115859/#review50191
-----------------------------------------------------------



kwin/effects/slide/slide.h
<https://git.reviewboard.kde.org/r/115859/#comment35293>

    It sounds strange to have a method being called "slot..." but not being under slots. Maybe another name is better nowadays?



kwin/effects/slide/slide.cpp
<https://git.reviewboard.kde.org/r/115859/#comment35294>

    suggestion: loop over m_backgroundContrastForcedBefore - you are only operating on them and the set should be much smaller



kwin/effects/slide/slide.cpp
<https://git.reviewboard.kde.org/r/115859/#comment35295>

    const bool
    
    in addtion I would check whether the window hasAlpha. No need to blur an opaque window


- Martin Gräßlin


On Feb. 19, 2014, 1:37 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115859/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 1:37 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Force-allow background contrast while sliding
> 
> When the sliding effect is active, the background blur of the panel
> would be disabled unless forced with WindowForceBackgroundContrastRole,
> which is actually what we want: during sliding, the backgroundcontrast
> effect would otherwise be disabled, leading to the panel and popups
> flickering between contrast enabled and disabled.
> 
> With this patch, the panel keeps its coloring during desktop changes.
> 
> 
> Diffs
> -----
> 
>   kwin/effects/slide/slide.h c8e0a84 
>   kwin/effects/slide/slide.cpp 8ecb2a6 
> 
> Diff: https://git.reviewboard.kde.org/r/115859/diff/
> 
> 
> Testing
> -------
> 
> Switched desktops, panel keeps color, fullscreen video player doesn't seem to be affected negatively, everything still works as expected, except that the flickering in Plasma Dialogs is gone.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140219/520c08eb/attachment-0001.html>