Review Request 115865: Adds new components for different sized labels

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115865/#review50139
-----------------------------------------------------------


What's wrong with PlasmaExtras.Title and PlasmaExtras.Heading? Those even scale with the font size, which these labels don't, they're hardcoded, so set a sufficiently large default font, and your BigLabel all of a sudden isn't big anymore. :)

- Sebastian Kügler


On Feb. 18, 2014, 10:26 a.m., Abhishek Shivanna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115865/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 10:26 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Introduced a new set of components called BigLabel, MediumLabel and SmallLabel which can be used to keep consistency in font sizes throughout the UI.
> 
> 
> Diffs
> -----
> 
>   components/CMakeLists.txt b085207 
>   components/labels/BigLabel.qml PRE-CREATION 
>   components/labels/MediumLabel.qml PRE-CREATION 
>   components/labels/SmallLabel.qml PRE-CREATION 
>   components/qmldir 3159132 
>   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
>   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
>   mediaelements/playlist/MultiplePlaylists.qml d94fe6e 
> 
> Diff: https://git.reviewboard.kde.org/r/115865/diff/
> 
> 
> Testing
> -------
> 
> Works as expected.
> 
> 
> File Attachments
> ----------------
> 
> The playlist name uses MediumLabel
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/02/18/66cf8d70-0b7a-4a88-8a8e-d913a313a06c__snapshot1.png
> 
> 
> Thanks,
> 
> Abhishek Shivanna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140218/526b1fcf/attachment.html>