<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115865/">https://git.reviewboard.kde.org/r/115865/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's wrong with PlasmaExtras.Title and PlasmaExtras.Heading? Those even scale with the font size, which these labels don't, they're hardcoded, so set a sufficiently large default font, and your BigLabel all of a sudden isn't big anymore. :)</pre>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On February 18th, 2014, 10:26 a.m. UTC, Abhishek Shivanna wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Abhishek Shivanna.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2014, 10:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Introduced a new set of components called BigLabel, MediumLabel and SmallLabel which can be used to keep consistency in font sizes throughout the UI.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>components/CMakeLists.txt <span style="color: grey">(b085207)</span></li>
<li>components/labels/BigLabel.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/labels/MediumLabel.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/labels/SmallLabel.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/qmldir <span style="color: grey">(3159132)</span></li>
<li>mediaelements/mediawelcome/BackendsListDelegate.qml <span style="color: grey">(e76af63)</span></li>
<li>mediaelements/mediawelcome/HomeScreenText.qml <span style="color: grey">(35cd20a)</span></li>
<li>mediaelements/playlist/MultiplePlaylists.qml <span style="color: grey">(d94fe6e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115865/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/02/18/66cf8d70-0b7a-4a88-8a8e-d913a313a06c__snapshot1.png">The playlist name uses MediumLabel</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>