Request for review

[Martin Klapetek]

Hey,

---------- Forwarded message ----------
> From: Conny Marco Menebröcker <admin at menebroecker-web.de>
> Date: Sat, Feb 15, 2014 at 7:44 PM
> Subject: Request for review
> To: kde-devel at kde.org
>
>
> Hello all,
>
>
> I have written my first plasmoid. I called it PlasmaTaskViewer,
> because it views the todos of a calendar file.
> In my case it shows the entries of my iPhone reminder app.
>
> I would be happy if someone reviews my code. I am especially
> interested in comments about the use of kcalcore and the data engine.
> But every other comment is welcome, too.
>

I just did a quick look over your code and tried to build it. You'll need
to explicitly look for KdepimLibs + set include_dirs in order to build
everywhere with no problems. Attached is a simple patch fixing the build.

I tried running it but have no .ics files present so can't really try it
out. Though your configuration dialog is somewhat too small and cannot be
resized easily for some reason. One more comment on the visuals - if I add
the applet is added on the desktop and you have no data/must set it up
first, it should show some label what to do, otherwise it's just an empty
Plasma-themed rectangle sitting on your desktop :)

Final note, we do not really support Applets based on QGraphicsView
anymore, the proper way to go is to use QML, which is way superior in tech
and ease of writing. I think this[1] should be a good way to get you
started :)

[1] -
http://techbase.kde.org/Development/Tutorials/Plasma/QML/GettingStarted

Cheers
-- 
Martin Klapetek | KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140216/f92b874c/attachment.html>
-------------- next part --------------
Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt	(revision 2)
+++ CMakeLists.txt	(working copy)
@@ -23,10 +23,11 @@
  
 # Find the required Libraries
 find_package(KDE4 REQUIRED)
+find_package (KdepimLibs REQUIRED)
 include(KDE4Defaults)
  
 add_definitions (${QT_DEFINITIONS} ${KDE4_DEFINITIONS})
-include_directories(
+include_directories(${KDEPIMLIBS_INCLUDE_DIRS}
    ${CMAKE_SOURCE_DIR}
    ${CMAKE_BINARY_DIR}
    ${KDE4_INCLUDES}
@@ -51,7 +52,7 @@
 target_link_libraries(plasma_dataengine_TaskViewerContainer 
 						${KDE4_PLASMA_LIBS} 
 						${KDE4_KIO_LIBS} 
-						kcalcore)
+						${KDEPIMLIBS_KCALCORE_LIBS})
  
 install(TARGETS plasma_applet_taskviewer
         DESTINATION ${PLUGIN_INSTALL_DIR})