Review Request 115727: Deafult for not executing kwalletmanager once a wallet is open

David Edmundson david at davidedmundson.co.uk
Thu Feb 13 23:06:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115727/#review49755
-----------------------------------------------------------

Ship it!


Makes a lot of sense.

Pedantic Comments:
fix the typo in your commit message.
Deafult -> Default
Execute the wallet -> Execute the walletManager

- David Edmundson


On Feb. 13, 2014, 5:13 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115727/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 5:13 p.m.)
> 
> 
> Review request for KDE Runtime, kde-workspace and Plasma.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Given that in 4.13 we want people to use pam to open the wallet it
> makes little sense to execute the wallet automatically.
> 
> Other commits changing the default have been pushed to runtime and
> kwalletmanager
> 
> 
> Diffs
> -----
> 
>   src/konfigurator/konfigurator.cpp b9f6edb 
>   src/manager/kwalletmanager.cpp 355fda7 
> 
> Diff: https://git.reviewboard.kde.org/r/115727/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140213/599092b3/attachment-0001.html>


More information about the Plasma-devel mailing list