Review Request 115513: [digital-clock] Make sure we remove seconds from time string when seconds are disabled

Commit Hook null at kde.org
Thu Feb 6 17:57:00 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115513/#review49147
-----------------------------------------------------------


This review has been submitted with commit 7a7ca1e18f5d96799913f4854176aea422ee3848 by Martin Klapetek to branch master.

- Commit Hook


On Feb. 6, 2014, 5:21 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115513/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 5:21 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 330813
>     http://bugs.kde.org/show_bug.cgi?id=330813
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> As https://bugs.kde.org/show_bug.cgi?id=330813 shows, Qt can fallback to "C" locale which returns seconds in "Short Format" time string (afaik it's the only one). This patch makes sure we always remove the seconds part from the format if seconds are not enabled in applet settings.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/digital-clock/contents/ui/DigitalClock.qml 5597d2c 
> 
> Diff: https://git.reviewboard.kde.org/r/115513/diff/
> 
> 
> Testing
> -------
> 
> Works with C locale.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140206/f9080ca5/attachment.html>


More information about the Plasma-devel mailing list