Review Request 115513: [digital-clock] Make sure we remove seconds from time string when seconds are disabled

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115513/#review49099
-----------------------------------------------------------

Ship it!



plasma/generic/applets/digital-clock/contents/ui/DigitalClock.qml
<https://git.reviewboard.kde.org/r/115513/#comment34678>

    Please cache the result of this method in a property somewhere. We're running a super slow regex every second.


- David Edmundson


On Feb. 6, 2014, 5:21 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115513/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 5:21 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 330813
>     http://bugs.kde.org/show_bug.cgi?id=330813
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> As https://bugs.kde.org/show_bug.cgi?id=330813 shows, Qt can fallback to "C" locale which returns seconds in "Short Format" time string (afaik it's the only one). This patch makes sure we always remove the seconds part from the format if seconds are not enabled in applet settings.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/digital-clock/contents/ui/DigitalClock.qml 5597d2c 
> 
> Diff: https://git.reviewboard.kde.org/r/115513/diff/
> 
> 
> Testing
> -------
> 
> Works with C locale.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140206/a8250b87/attachment-0001.html>