Review Request 115435: Add an option to uniform the style of time and data in digital clock applet

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115435/#review48793
-----------------------------------------------------------



plasma/generic/applets/digital-clock/clock.cpp
<https://git.reviewboard.kde.org/r/115435/#comment34448>

    I'm confused as to what we're trying to do here.
    
    There's a new option to unify the date stamp text style with the clock, but it won't happen if the user also changes the colour of the clock text?



plasma/generic/applets/digital-clock/clockConfig.ui
<https://git.reviewboard.kde.org/r/115435/#comment34447>

    Being in a frozen branch, I don't think we are able to introduce new strings.
    Sorry.


- David Edmundson


On Feb. 2, 2014, 12:31 p.m., Yichao Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115435/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2014, 12:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> This patch adds an option to uniform the style (mainly font) of time and data in digital clock applet.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/digital-clock/clock.h f4822ec 
>   plasma/generic/applets/digital-clock/clock.cpp f26e328 
>   plasma/generic/applets/digital-clock/clockConfig.ui b58fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/115435/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140203/1d768f21/attachment.html>