Review Request 115435: Add an option to uniform the style of time and data in digital clock applet

Bhushan Shah bhush94 at gmail.com
Sun Feb 2 13:02:27 UTC 2014



> On Feb. 2, 2014, 6:03 p.m., Yichao Zhou wrote:
> > Ship It!
> 
> Yichao Zhou wrote:
>     Sorry I don't know what really happens.  What is "Ship It"...

When you open review request maintainer of that component reviews your patch, if he/she will find patch useful give you "Ship it!" and you can commit it, otherwise he/she will open issues. You don't have to give "Ship It!" to your own review request.


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115435/#review48764
-----------------------------------------------------------


On Feb. 2, 2014, 6:01 p.m., Yichao Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115435/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2014, 6:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> This patch adds an option to uniform the style (mainly font) of time and data in digital clock applet.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/digital-clock/clock.h f4822ec 
>   plasma/generic/applets/digital-clock/clock.cpp f26e328 
>   plasma/generic/applets/digital-clock/clockConfig.ui b58fb0b 
> 
> Diff: https://git.reviewboard.kde.org/r/115435/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140202/305b2183/attachment.html>


More information about the Plasma-devel mailing list