Review Request 121762: Fix build on FreeBSD

[Alex Richardson]

> On Dez. 30, 2014, 7:05 nachm., Raphael Kubo da Costa wrote:
> > kcms/keyboard/CMakeLists.txt, line 127
> > <https://git.reviewboard.kde.org/r/121762/diff/1/?file=337446#file337446line127>
> >
> >     `-fexceptions` is already set above.

AFAIK set_source_files_properties doesn't append, it replaces. Fixed in the new patch by using set_property(SOURCE ... APPEND)


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121762/#review72792
-----------------------------------------------------------


On Dez. 30, 2014, 6:35 nachm., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121762/
> -----------------------------------------------------------
> 
> (Updated Dez. 30, 2014, 6:35 nachm.)
> 
> 
> Review request for Plasma and Raphael Kubo da Costa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Fix build with clang 3.4
> 
> Clang doesn't allow variable length arrays of non-POD data types
> Also it seems that the default template instantion depth is not
> enough to compile geometry_parser.cpp
> 
> ------
> 
> Add missing includes of cmath and cstdlib
> 
> -----
> 
> Fix clang warning -Wmismatched-tags
> 
> -----
> 
> 
> Fix build of geometry_parser test with clang
> 
> We need to increase the template instantiation depth
> 
> -----
> 
> Fix more -Wmismatched-tag warnings
> 
> ----
> 
> Fix build of kapplymousetheme if X11 isn't installed to /usr
> 
> ----
> 
> 
> Fix build of phonon KCM if libcanberra is not in /usr
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/bindings.h d59790752ced2ec8fd77269f75012e74ccda4cc4 
>   kcms/keyboard/flags.h 3957a983f06044e8f5ed130afc4774f8c644ed8c 
>   kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5ebc264d69555063668cb68be5255b3030 
>   kcms/keyboard/kcm_keyboard.h c88fe3dd8540df07eb886b3119dfbe30fab2844b 
>   kcms/keyboard/kcm_keyboard_widget.h 5994ea4815d6398afaf6765b77a2bc8cd349f780 
>   kcms/keyboard/kcm_view_models.h 872e26185248c6dfb8d8808115865ae18596cbea 
>   kcms/keyboard/kcmmisc.cpp 9aed7de2a8a63aa546dc9484eea0edadcc64ec66 
>   containments/folder/plugin/positioner.cpp c24827197bf20b4cb55a6b885f023074f179159c 
>   kcms/input/CMakeLists.txt a2b72a45a3b694b7fa367abf33d0752b0dc9734b 
>   kcms/keyboard/CMakeLists.txt 3db5dc3f938bbe25259067783bda4fdd882f60f6 
>   kcms/keyboard/keyboard_daemon.h 4d7587f9113edea31dd07f23d658818941731df2 
>   kcms/keyboard/layout_tray_icon.h 8338bf26307627747fb434ae8e0903050142aef4 
>   kcms/keyboard/layouts_menu.h db2f3ff5844e16340ad3ca6102e6b1c4866ad8db 
>   kcms/keyboard/preview/kbpreviewframe.cpp 9735eb02ac6875bb3905fb0bf8183a9d97e0e3e4 
>   kcms/keyboard/tests/CMakeLists.txt bd62c7d281766bc5c04b0b1e933861d258241cf7 
>   kcms/keyboard/xkb_helper.h d3dab1d9b05784ae463db44ab941119e5b214986 
>   kcms/phonon/CMakeLists.txt 8f964e2041cc812bf70f6a48e2915427f088b990 
> 
> Diff: https://git.reviewboard.kde.org/r/121762/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141230/4b09f1c7/attachment.html>