Review Request 121762: Fix build on FreeBSD

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121762/#review72792
-----------------------------------------------------------



kcms/keyboard/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121762/#comment50691>

    `-fexceptions` is already set above.



kcms/keyboard/flags.h
<https://git.reviewboard.kde.org/r/121762/#comment50690>

    I'd move the `struct` forward declarations after the `class` ones here and in the other places that have been changed.



kcms/keyboard/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121762/#comment50692>

    `-fexceptions` is already set by the `keyboard_preview_unit_tests` macro, which also allows you to remove the commented out line below.



kcms/phonon/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121762/#comment50694>

    In this case, I think it pays off to write a proper find module instead of the `pkg_check_module` call we currently have -- in fact, it appears I wrote one a while ago for KMix that's still in the repository.


In addition to the points I mentioned inline, it would be good if in your final commit messages you pasted the actual errors clang is throwing at you for posterity.

- Raphael Kubo da Costa


On Dec. 30, 2014, 8:35 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121762/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 8:35 p.m.)
> 
> 
> Review request for Plasma and Raphael Kubo da Costa.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Fix build with clang 3.4
> 
> Clang doesn't allow variable length arrays of non-POD data types
> Also it seems that the default template instantion depth is not
> enough to compile geometry_parser.cpp
> 
> ------
> 
> Add missing includes of cmath and cstdlib
> 
> -----
> 
> Fix clang warning -Wmismatched-tags
> 
> -----
> 
> 
> Fix build of geometry_parser test with clang
> 
> We need to increase the template instantiation depth
> 
> -----
> 
> Fix more -Wmismatched-tag warnings
> 
> ----
> 
> Fix build of kapplymousetheme if X11 isn't installed to /usr
> 
> ----
> 
> 
> Fix build of phonon KCM if libcanberra is not in /usr
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/bindings.h d59790752ced2ec8fd77269f75012e74ccda4cc4 
>   kcms/keyboard/flags.h 3957a983f06044e8f5ed130afc4774f8c644ed8c 
>   kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5ebc264d69555063668cb68be5255b3030 
>   kcms/keyboard/kcm_keyboard.h c88fe3dd8540df07eb886b3119dfbe30fab2844b 
>   kcms/keyboard/kcm_keyboard_widget.h 5994ea4815d6398afaf6765b77a2bc8cd349f780 
>   kcms/keyboard/kcm_view_models.h 872e26185248c6dfb8d8808115865ae18596cbea 
>   kcms/keyboard/kcmmisc.cpp 9aed7de2a8a63aa546dc9484eea0edadcc64ec66 
>   containments/folder/plugin/positioner.cpp c24827197bf20b4cb55a6b885f023074f179159c 
>   kcms/input/CMakeLists.txt a2b72a45a3b694b7fa367abf33d0752b0dc9734b 
>   kcms/keyboard/CMakeLists.txt 3db5dc3f938bbe25259067783bda4fdd882f60f6 
>   kcms/keyboard/keyboard_daemon.h 4d7587f9113edea31dd07f23d658818941731df2 
>   kcms/keyboard/layout_tray_icon.h 8338bf26307627747fb434ae8e0903050142aef4 
>   kcms/keyboard/layouts_menu.h db2f3ff5844e16340ad3ca6102e6b1c4866ad8db 
>   kcms/keyboard/preview/kbpreviewframe.cpp 9735eb02ac6875bb3905fb0bf8183a9d97e0e3e4 
>   kcms/keyboard/tests/CMakeLists.txt bd62c7d281766bc5c04b0b1e933861d258241cf7 
>   kcms/keyboard/xkb_helper.h d3dab1d9b05784ae463db44ab941119e5b214986 
>   kcms/phonon/CMakeLists.txt 8f964e2041cc812bf70f6a48e2915427f088b990 
> 
> Diff: https://git.reviewboard.kde.org/r/121762/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141230/ae40d81d/attachment-0001.html>