Review Request 121761: Fix build on FreeBSD
Alex Richardson
arichardson.kde at gmail.com
Tue Dec 30 18:46:32 UTC 2014
> On Dez. 30, 2014, 6:42 nachm., Raphael Kubo da Costa wrote:
> > I'd keep the `errno.h` includes alphabetically sorted, and commit each of those changes (errno, then X11 dependencies etc) separately. Other than that, looks good to me.
Those are three separate commits. I thought having 3 RR just for those small issues is too much
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121761/#review72789
-----------------------------------------------------------
On Dez. 30, 2014, 6:33 nachm., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121761/
> -----------------------------------------------------------
>
> (Updated Dez. 30, 2014, 6:33 nachm.)
>
>
> Review request for Plasma and Raphael Kubo da Costa.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Add missing errno.h include
>
> Wrap Linux-only signals in #ifdef Q_OS_LINUX
>
> Fix build with X11 not installed to /usr
>
>
> Diffs
> -----
>
> drkonqi/detachedprocessmonitor.cpp 85a87874c6e9ce47856a01195b42aef9f3a4991a
> drkonqi/systeminformation.cpp 8f5fc7fe789a4bbe23f178e7e940ba1d1a1b59db
> ksmserver/CMakeLists.txt 84a8aa393dfb6ed4671094d1fccbb3c79c53f9af
> ksmserver/screenlocker/greeter/authenticator.cpp ad60f0bd0076cd9c8c3875f13dc92b5da253bb1a
> ksmserver/screenlocker/greeter/autotests/killtest.cpp 6f2ef114459b5d641e357f3a817b82e7af2e72a3
> libkworkspace/CMakeLists.txt 53ce6108bd91f87108206fca02ac303dadf069e1
>
> Diff: https://git.reviewboard.kde.org/r/121761/diff/
>
>
> Testing
> -------
>
> compiles, still compiles on linux
>
>
> Thanks,
>
> Alex Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141230/827eb222/attachment-0001.html>
More information about the Plasma-devel
mailing list