<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121761/">https://git.reviewboard.kde.org/r/121761/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Dezember 30th, 2014, 6:42 nachm. GMT, <b>Raphael Kubo da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd keep the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">errno.h</code> includes alphabetically sorted, and commit each of those changes (errno, then X11 dependencies etc) separately. Other than that, looks good to me.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Those are three separate commits. I thought having 3 RR just for those small issues is too much</p></pre>
<br />
<p>- Alex</p>
<br />
<p>On Dezember 30th, 2014, 6:33 nachm. GMT, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Raphael Kubo da Costa.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Dez. 30, 2014, 6:33 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add missing errno.h include</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wrap Linux-only signals in #ifdef Q_OS_LINUX</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix build with X11 not installed to /usr</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiles, still compiles on linux</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/detachedprocessmonitor.cpp <span style="color: grey">(85a87874c6e9ce47856a01195b42aef9f3a4991a)</span></li>
<li>drkonqi/systeminformation.cpp <span style="color: grey">(8f5fc7fe789a4bbe23f178e7e940ba1d1a1b59db)</span></li>
<li>ksmserver/CMakeLists.txt <span style="color: grey">(84a8aa393dfb6ed4671094d1fccbb3c79c53f9af)</span></li>
<li>ksmserver/screenlocker/greeter/authenticator.cpp <span style="color: grey">(ad60f0bd0076cd9c8c3875f13dc92b5da253bb1a)</span></li>
<li>ksmserver/screenlocker/greeter/autotests/killtest.cpp <span style="color: grey">(6f2ef114459b5d641e357f3a817b82e7af2e72a3)</span></li>
<li>libkworkspace/CMakeLists.txt <span style="color: grey">(53ce6108bd91f87108206fca02ac303dadf069e1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121761/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>