Review Request 121398: Drop configuration page that does nothing

[Albert Astals Cid]

> On des. 9, 2014, 9:12 a.m., David Edmundson wrote:
> > kcms/knotify/knotify.cpp, line 73
> > <https://git.reviewboard.kde.org/r/121398/diff/1/?file=332313#file332313line73>
> >
> >     then we don't need this if we only have one tab?

I won't pretend to be the best UI designer ever. Are you asking for me to remove it?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121398/#review71612
-----------------------------------------------------------


On des. 8, 2014, 10:55 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121398/
> -----------------------------------------------------------
> 
> (Updated des. 8, 2014, 10:55 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Klapetek.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> knotifications does not obey this setting
> 
> 
> Diffs
> -----
> 
>   kcms/knotify/CMakeLists.txt 333474d 
>   kcms/knotify/knotify.h fc73b75 
>   kcms/knotify/knotify.cpp b05c011 
> 
> Diff: https://git.reviewboard.kde.org/r/121398/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141219/2f334e59/attachment.html>