Review Request 121398: Drop configuration page that does nothing

David Edmundson david at davidedmundson.co.uk
Tue Dec 9 09:12:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121398/#review71612
-----------------------------------------------------------


I think this means we can kill a bit more.
But +1 to everything that is in this diff.


kcms/knotify/knotify.cpp
<https://git.reviewboard.kde.org/r/121398/#comment49935>

    then we don't need this if we only have one tab?


- David Edmundson


On Dec. 8, 2014, 10:55 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121398/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 10:55 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Klapetek.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> knotifications does not obey this setting
> 
> 
> Diffs
> -----
> 
>   kcms/knotify/CMakeLists.txt 333474d 
>   kcms/knotify/knotify.h fc73b75 
>   kcms/knotify/knotify.cpp b05c011 
> 
> Diff: https://git.reviewboard.kde.org/r/121398/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141209/fed29946/attachment.html>


More information about the Plasma-devel mailing list