Review Request 121476: Port showdesktop applet to Plasma Next
Martin Gräßlin
mgraesslin at kde.org
Wed Dec 17 14:27:22 UTC 2014
> On Dec. 17, 2014, 1:30 p.m., Vishesh Handa wrote:
> > I've tested it out, and it works.
> >
> > I'm not too sure about the X11 parts, but given that no-one who knows about this X11 stuff has commented so far, please ship it.
> I'm not too sure about the X11 parts, but given that no-one who knows about this X11 stuff has commented so far, please ship it.
well, you could also just ping people who know the X11 parts. I don't follow all review requests and cannot know that the code in question uses X11.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121476/#review72173
-----------------------------------------------------------
On Dec. 13, 2014, 4:55 p.m., Ashish Madeti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121476/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2014, 4:55 p.m.)
>
>
> Review request for Plasma and Bhushan Shah.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> Ported the "Show Desktop" applet to Plasma Next.
> Most of the code is derived from the old showdesktop applet.
>
>
> Diffs
> -----
>
> CMakeLists.txt db03015
> applets/CMakeLists.txt ccd1bf7
> applets/showdesktop/CMakeLists.txt eb53207
> applets/showdesktop/package/contents/config/main.xml PRE-CREATION
> applets/showdesktop/package/contents/ui/main.qml PRE-CREATION
> applets/showdesktop/package/metadata.desktop PRE-CREATION
> applets/showdesktop/plasma-applet-showdesktop.desktop f36a1da
> applets/showdesktop/plugin/qmldir PRE-CREATION
> applets/showdesktop/plugin/showdesktop.h PRE-CREATION
> applets/showdesktop/plugin/showdesktop.cpp PRE-CREATION
> applets/showdesktop/plugin/showdesktopplugin.h PRE-CREATION
> applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION
> applets/showdesktop/showdesktop.h 5aeb848
> applets/showdesktop/showdesktop.cpp d712519
>
> Diff: https://git.reviewboard.kde.org/r/121476/diff/
>
>
> Testing
> -------
>
> Tested the applet locally, working fine.
>
>
> Thanks,
>
> Ashish Madeti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141217/393dceda/attachment.html>
More information about the Plasma-devel
mailing list