Review Request 121476: Port showdesktop applet to Plasma Next

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121476/#review72187
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/121476/#comment50352>

    please do not REQUIRE X11Extras. It should be an optional dependency



applets/showdesktop/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121476/#comment50353>

    only link against Qt5::X11Extras if it is found.



applets/showdesktop/plugin/showdesktop.h
<https://git.reviewboard.kde.org/r/121476/#comment50349>

    it's about showing desktop - not minimizeAll. That's a huge difference (there's a config option in KWin on how it's supposed to behave)



applets/showdesktop/plugin/showdesktop.cpp
<https://git.reviewboard.kde.org/r/121476/#comment50350>

    You need to check whether you have X11 with a
    #if HAVE_X11
    #include...
    #endif



applets/showdesktop/plugin/showdesktop.cpp
<https://git.reviewboard.kde.org/r/121476/#comment50351>

    this is X11 specific API: it needs to be in ifdefs and needs a runtime check for correct platform:
    
    #if HAVE_X11
    if (QX11Info::isPlatformX11()) {
      // X11 specific part
    }
    #endif


- Martin Gräßlin


On Dec. 13, 2014, 4:55 p.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121476/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2014, 4:55 p.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Ported the "Show Desktop" applet to Plasma Next.
> Most of the code is derived from the old showdesktop applet.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt db03015 
>   applets/CMakeLists.txt ccd1bf7 
>   applets/showdesktop/CMakeLists.txt eb53207 
>   applets/showdesktop/package/contents/config/main.xml PRE-CREATION 
>   applets/showdesktop/package/contents/ui/main.qml PRE-CREATION 
>   applets/showdesktop/package/metadata.desktop PRE-CREATION 
>   applets/showdesktop/plasma-applet-showdesktop.desktop f36a1da 
>   applets/showdesktop/plugin/qmldir PRE-CREATION 
>   applets/showdesktop/plugin/showdesktop.h PRE-CREATION 
>   applets/showdesktop/plugin/showdesktop.cpp PRE-CREATION 
>   applets/showdesktop/plugin/showdesktopplugin.h PRE-CREATION 
>   applets/showdesktop/plugin/showdesktopplugin.cpp PRE-CREATION 
>   applets/showdesktop/showdesktop.h 5aeb848 
>   applets/showdesktop/showdesktop.cpp d712519 
> 
> Diff: https://git.reviewboard.kde.org/r/121476/diff/
> 
> 
> Testing
> -------
> 
> Tested the applet locally, working fine.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141217/377b9412/attachment-0001.html>