Review Request 121530: Remove lock screen on suspend

[Martin Gräßlin]

> On Dec. 15, 2014, 11:55 a.m., Kai Uwe Broulik wrote:
> > daemon/actions/bundled/suspendsession.cpp, line 112
> > <https://git.reviewboard.kde.org/r/121530/diff/1/?file=333360#file333360line112>
> >
> >     It is not guaranteed that the backend actually uses logind.
> >     
> >     Backend could be
> >     - PowerDevilHALBackend, which doesn't support that
> >     - PowerDevilUPowerBackend which uses logind only if available and systemd version >= 195
> >     
> >     So perhaps it should become possible to query the backend in advance whether it supports logind and lock manually if not.

or we declare lock screen on suspend as unsupported on non-logind.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121530/#review72036
-----------------------------------------------------------


On Dec. 15, 2014, 11:45 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121530/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2014, 11:45 a.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> This is handled internally in the screenlocker daemon using logind.
> It requires that powerdevil is supending through logind, though.
> 
> 
> Diffs
> -----
> 
>   daemon/actions/bundled/suspendsession.h 0c319f266ecfe6e712abe436e7891298d853c592 
>   daemon/actions/bundled/suspendsession.cpp 7308b7e7b797438aa5e772924af0014ddc8067cd 
>   kcmodule/global/GeneralPage.cpp 1f56a6a4aa350b18bfea082c99964671154c1c31 
>   kcmodule/global/generalPage.ui 780b701b580ea71d1218632b0596ad947576384d 
>   PowerDevilSettings.kcfg cd103c6d8da47be210b954e324bec3fc3fae5467 
> 
> Diff: https://git.reviewboard.kde.org/r/121530/diff/
> 
> 
> Testing
> -------
> 
> it compiles. I'm not familiar enough with powerdevil to know whether this is correct.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141215/a8164d73/attachment-0001.html>