Review Request 121530: Remove lock screen on suspend
Kai Uwe Broulik
kde at privat.broulik.de
Mon Dec 15 10:55:34 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121530/#review72036
-----------------------------------------------------------
daemon/actions/bundled/suspendsession.cpp
<https://git.reviewboard.kde.org/r/121530/#comment50224>
It is not guaranteed that the backend actually uses logind.
Backend could be
- PowerDevilHALBackend, which doesn't support that
- PowerDevilUPowerBackend which uses logind only if available and systemd version >= 195
So perhaps it should become possible to query the backend in advance whether it supports logind and lock manually if not.
- Kai Uwe Broulik
On Dez. 15, 2014, 10:45 vorm., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121530/
> -----------------------------------------------------------
>
> (Updated Dez. 15, 2014, 10:45 vorm.)
>
>
> Review request for Plasma and Solid.
>
>
> Repository: powerdevil
>
>
> Description
> -------
>
> This is handled internally in the screenlocker daemon using logind.
> It requires that powerdevil is supending through logind, though.
>
>
> Diffs
> -----
>
> daemon/actions/bundled/suspendsession.h 0c319f266ecfe6e712abe436e7891298d853c592
> daemon/actions/bundled/suspendsession.cpp 7308b7e7b797438aa5e772924af0014ddc8067cd
> kcmodule/global/GeneralPage.cpp 1f56a6a4aa350b18bfea082c99964671154c1c31
> kcmodule/global/generalPage.ui 780b701b580ea71d1218632b0596ad947576384d
> PowerDevilSettings.kcfg cd103c6d8da47be210b954e324bec3fc3fae5467
>
> Diff: https://git.reviewboard.kde.org/r/121530/diff/
>
>
> Testing
> -------
>
> it compiles. I'm not familiar enough with powerdevil to know whether this is correct.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141215/7cb69efa/attachment.html>
More information about the Plasma-devel
mailing list