Review Request 121529: Let others know that we support persistent notifications

[Martin Klapetek]

> On Dec. 15, 2014, 10:59 a.m., Martin Klapetek wrote:
> > This spec is however gnome's own extension of the original spec, which has no such stuff. Is there an actual use case why this would be needed?
> > 
> > More general question - should we be implementing their extensions?
> 
> Jan Grulich wrote:
>     A guy from RedHat working on ABRT asked me today if we support persistent notifications, he was looking at org.freedesktop.Notifications and checking if there is "persistence" keyword in supported capabilities.
>     
>     I don't see anything wrong on implementing their extensions, in this case it could be useful.

Personally I find it quite odd to have that in the capabilities, because the spec itself actually has the concept of "persistence" in the basic principles, so the client implementing the interface _must_ have support for persistent notifications, in some way.

As for implmenting a 3rd party extensions, this one specifically...I for one dislike the way they are handling it with in the typical Gnome fashion - "we do our own thing, don't care about the others, you all succumb to our doings". It could have continued being part of the cross-desktop galago spec but this way....I'll raise this on the meeting today to get a general opinion on it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121529/#review72029
-----------------------------------------------------------


On Dec. 15, 2014, 10:37 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121529/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2014, 10:37 a.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> According to our implementation of org.freedesktop.Notifications we don't support persistent notifications, which is not true. This patch adds "persistence" keyword to the list of capabilities.
> 
> See https://developer.gnome.org/notification-spec/#id2825605.
> 
> 
> Diffs
> -----
> 
>   dataengines/notifications/notificationsengine.cpp d4b7f19 
> 
> Diff: https://git.reviewboard.kde.org/r/121529/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141215/99044ad4/attachment.html>