Review Request 121529: Let others know that we support persistent notifications
Jan Grulich
jgrulich at redhat.com
Mon Dec 15 10:09:37 UTC 2014
> On Pro. 15, 2014, 9:59 dop., Martin Klapetek wrote:
> > This spec is however gnome's own extension of the original spec, which has no such stuff. Is there an actual use case why this would be needed?
> >
> > More general question - should we be implementing their extensions?
A guy from RedHat working on ABRT asked me today if we support persistent notifications, he was looking at org.freedesktop.Notifications and checking if there is "persistence" keyword in supported capabilities.
I don't see anything wrong on implementing their extensions, in this case it could be useful.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121529/#review72029
-----------------------------------------------------------
On Pro. 15, 2014, 9:37 dop., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121529/
> -----------------------------------------------------------
>
> (Updated Pro. 15, 2014, 9:37 dop.)
>
>
> Review request for Plasma and Martin Klapetek.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> According to our implementation of org.freedesktop.Notifications we don't support persistent notifications, which is not true. This patch adds "persistence" keyword to the list of capabilities.
>
> See https://developer.gnome.org/notification-spec/#id2825605.
>
>
> Diffs
> -----
>
> dataengines/notifications/notificationsengine.cpp d4b7f19
>
> Diff: https://git.reviewboard.kde.org/r/121529/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141215/bf0ad4bd/attachment.html>
More information about the Plasma-devel
mailing list