Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

Dmitry Shachnev mitya57 at gmail.com
Thu Dec 11 12:32:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121439/
-----------------------------------------------------------

(Updated Dec. 11, 2014, 12:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Repository: frameworkintegration


Description
-------

Documentation of KStatusNotifierItem::showMessage() says:

const QString &icon | icon to be shown to the user

So we need name of the icon here, not name of the theme.


Diffs
-----

  src/platformtheme/kdeplatformsystemtrayicon.cpp 51f31ad 

Diff: https://git.reviewboard.kde.org/r/121439/diff/


Testing
-------


Thanks,

Dmitry Shachnev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141211/a379f7b6/attachment.html>


More information about the Plasma-devel mailing list