Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

[Dmitry Shachnev]

> On Dez. 11, 2014, 12:18 nachm., Martin Klapetek wrote:
> > Btw. do you have an actual bug where this can be seen/tested? Good spot otherwise!
> 
> Martin Gräßlin wrote:
>     I had seen something which I did not understand in the past: owncloud sync client was for a short time Qt 5.3 based and the icon was just broken and I didn't understand it.

No bug. I was just playing with my own QPlatformSystemTrayIcon implementation, looked at your code and spotted it.


- Dmitry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121439/#review71793
-----------------------------------------------------------


On Dez. 11, 2014, 8:26 vorm., Dmitry Shachnev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121439/
> -----------------------------------------------------------
> 
> (Updated Dez. 11, 2014, 8:26 vorm.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Documentation of KStatusNotifierItem::showMessage() says:
> 
> const QString &icon | icon to be shown to the user
> 
> So we need name of the icon here, not name of the theme.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp 51f31ad 
> 
> Diff: https://git.reviewboard.kde.org/r/121439/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Shachnev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141211/c84b01e8/attachment-0001.html>