Review Request 121402: Allow user to customise wallpaper used in the lock screen.

[Martin Gräßlin]

> On Dec. 9, 2014, 12:01 p.m., Martin Gräßlin wrote:
> > lookandfeel/contents/lockscreen/LockScreen.qml, line 36
> > <https://git.reviewboard.kde.org/r/121402/diff/1/?file=332325#file332325line36>
> >
> >     shouldn't you compare whether backgroundPath is empty? That's checking whether the variable is defined, isn't it?
> 
> David Edmundson wrote:
>     This is fine, but you did make me doubt myself :) https://paste.kde.org/pnepmtaen

oh javascript...


> On Dec. 9, 2014, 12:01 p.m., Martin Gräßlin wrote:
> > ksmserver/screenlocker/kcm/kcm.ui, lines 84-104
> > <https://git.reviewboard.kde.org/r/121402/diff/1/?file=332322#file332322line84>
> >
> >     How does one switch back to the default background?
> 
> David Edmundson wrote:
>     left click the button, you get a menu with two options:
>      - open image...
>      - clear image

that's not really obvious. It's probably good enough, but maybe we need to get input from usability experts.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/#review71619
-----------------------------------------------------------


On Dec. 9, 2014, 1:29 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121402/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2014, 1:29 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Allow user to customise wallpaper used in the lock screen.
> 
> Nothing very fancy it's the same plain image approach we use in SDDM. 
> Default behaviour is unchanged. We can always expand it later.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/kcm/kcm.ui c891cc9 
>   ksmserver/screenlocker/kcm/selectimagebutton.h PRE-CREATION 
>   ksmserver/screenlocker/kcm/selectimagebutton.cpp PRE-CREATION 
>   lookandfeel/contents/lockscreen/LockScreen.qml ca9beb2 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 60bd347 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 5207615 
>   ksmserver/screenlocker/kcm/CMakeLists.txt a23a0fc 
>   ksmserver/screenlocker/kcm/kcm.cpp 0f74c45 
> 
> Diff: https://git.reviewboard.kde.org/r/121402/diff/
> 
> 
> Testing
> -------
> 
> Opened lockscreen.
> Most code is tried and tested in the SDDM KCM.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141209/8e131a6d/attachment-0001.html>