Review Request 121402: Allow user to customise wallpaper used in the lock screen.

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/#review71621
-----------------------------------------------------------



ksmserver/screenlocker/kcm/selectimagebutton.h
<https://git.reviewboard.kde.org/r/121402/#comment49943>

    QUrl?



ksmserver/screenlocker/kcm/selectimagebutton.cpp
<https://git.reviewboard.kde.org/r/121402/#comment49944>

    Coding style



ksmserver/screenlocker/kcm/selectimagebutton.cpp
<https://git.reviewboard.kde.org/r/121402/#comment49942>

    That seems unneeded



lookandfeel/contents/lockscreen/LockScreen.qml
<https://git.reviewboard.kde.org/r/121402/#comment49946>

    Nifty :)



lookandfeel/contents/lockscreen/LockScreen.qml
<https://git.reviewboard.kde.org/r/121402/#comment49945>

    if (status === Image.Error)
    
    You also might want to avoid an endless loop when the default wallpaper failed too


- Kai Uwe Broulik


On Dez. 9, 2014, 10:56 vorm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121402/
> -----------------------------------------------------------
> 
> (Updated Dez. 9, 2014, 10:56 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Allow user to customise wallpaper used in the lock screen.
> 
> Nothing very fancy it's the same plain image approach we use in SDDM. 
> Default behaviour is unchanged. We can always expand it later.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/lockscreen/LockScreen.qml ca9beb2 
>   ksmserver/screenlocker/kcm/CMakeLists.txt a23a0fc 
>   ksmserver/screenlocker/kcm/kcm.cpp 0f74c45 
>   ksmserver/screenlocker/kcm/kcm.ui c891cc9 
>   ksmserver/screenlocker/kcm/selectimagebutton.h PRE-CREATION 
>   ksmserver/screenlocker/kcm/selectimagebutton.cpp PRE-CREATION 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 60bd347 
>   ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 5207615 
> 
> Diff: https://git.reviewboard.kde.org/r/121402/diff/
> 
> 
> Testing
> -------
> 
> Opened lockscreen.
> Most code is tried and tested in the SDDM KCM.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141209/83b838b8/attachment-0001.html>