Review Request 121348: Adaptive ui for Active settings

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121348/#review71428
-----------------------------------------------------------

Ship it!


That's straight-forward. I'd say put it in, and we can address Kai Uwe's comments from there on.

- Sebastian Kügler


On Dec. 4, 2014, 1:42 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121348/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 1:42 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: plasma-mobile
> 
> 
> Description
> -------
> 
> when the width of the settings app is less than a certain grid unit value (kinda arbitrary, but dpi aware) switch from showing everything when a module is open to a 2 step process, showing only the menu vs only the currently open module (plus a back button n a toolbar at the bottom of the screen)
> 
> 
> Diffs
> -----
> 
>   applications/settings/package/contents/ui/ActiveSettings.qml 341b31c 
> 
> Diff: https://git.reviewboard.kde.org/r/121348/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> adapt.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/12/04/c307d23a-2069-4dca-bf0d-6c20e851026f__adapt.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141205/32f776dd/attachment.html>