Review Request 121348: Adaptive ui for Active settings
Kai Uwe Broulik
kde at privat.broulik.de
Thu Dec 4 13:54:52 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121348/#review71346
-----------------------------------------------------------
applications/settings/package/contents/ui/ActiveSettings.qml
<https://git.reviewboard.kde.org/r/121348/#comment49819>
This only animates the transition to compact mode, no?
applications/settings/package/contents/ui/ActiveSettings.qml
<https://git.reviewboard.kde.org/r/121348/#comment49820>
You might want to use an XAnimator here, given there's nothing anchored to this item, to prevent stuttering when possibly heavy relayoutings take place
- Kai Uwe Broulik
On Dez. 4, 2014, 1:42 nachm., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121348/
> -----------------------------------------------------------
>
> (Updated Dez. 4, 2014, 1:42 nachm.)
>
>
> Review request for Plasma and Sebastian Kügler.
>
>
> Repository: plasma-mobile
>
>
> Description
> -------
>
> when the width of the settings app is less than a certain grid unit value (kinda arbitrary, but dpi aware) switch from showing everything when a module is open to a 2 step process, showing only the menu vs only the currently open module (plus a back button n a toolbar at the bottom of the screen)
>
>
> Diffs
> -----
>
> applications/settings/package/contents/ui/ActiveSettings.qml 341b31c
>
> Diff: https://git.reviewboard.kde.org/r/121348/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> adapt.png
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/04/c307d23a-2069-4dca-bf0d-6c20e851026f__adapt.png
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141204/2724bb4a/attachment.html>
More information about the Plasma-devel
mailing list