Review Request 121219: Load IconItem immediately upon componentComplete()

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121219/#review71395
-----------------------------------------------------------



src/declarativeimports/core/iconitem.h
<https://git.reviewboard.kde.org/r/121219/#comment49843>

    add Q_DECL_OVERRIDE



src/declarativeimports/core/iconitem.cpp
<https://git.reviewboard.kde.org/r/121219/#comment49844>

    if we have an empty string, lets just call loadPixmap() immediatey unconditionally.
    
    There's no point having a timer for unloading everything as it will be super fast.



src/declarativeimports/core/iconitem.cpp
<https://git.reviewboard.kde.org/r/121219/#comment49842>

    there's a better size check on line 314 that clears up some memory and stops some timers


- David Edmundson


On Dec. 4, 2014, 8:27 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121219/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 8:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This makes the IconItem load the icon immediately after component creation and not wait 150ms there for no reason which prevents eg. flickering in the OSD when it shows up.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h 8aecd17 
>   src/declarativeimports/core/iconitem.cpp ed3bb97 
> 
> Diff: https://git.reviewboard.kde.org/r/121219/diff/
> 
> 
> Testing
> -------
> 
> Totally forgot about that, just took it for granted that the OSD wouldn't flicker anymore.
> Resizing applets still has it scale the texture before re-rendering it.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141205/032f08d5/attachment.html>