Review Request 121219: Load IconItem immediately upon componentComplete()

Kai Uwe Broulik kde at privat.broulik.de
Thu Dec 4 20:27:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121219/
-----------------------------------------------------------

(Updated Dez. 4, 2014, 8:27 nachm.)


Review request for Plasma.


Summary (updated)
-----------------

Load IconItem immediately upon componentComplete()


Repository: plasma-framework


Description (updated)
-------

This makes the IconItem load the icon immediately after component creation and not wait 150ms there for no reason which prevents eg. flickering in the OSD when it shows up.


Diffs (updated)
-----

  src/declarativeimports/core/iconitem.h 8aecd17 
  src/declarativeimports/core/iconitem.cpp ed3bb97 

Diff: https://git.reviewboard.kde.org/r/121219/diff/


Testing (updated)
-------

Totally forgot about that, just took it for granted that the OSD wouldn't flicker anymore.
Resizing applets still has it scale the texture before re-rendering it.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141204/8a7f0701/attachment.html>


More information about the Plasma-devel mailing list