Review Request 121346: Some fixes on battery monitor

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121346/#review71328
-----------------------------------------------------------


Nice!

I will borrow that angleDelta trick for the Plasma calendar where I used a similar, yet different and worse, approach [1].

The brightness percent value was there for a reason. Powerdevil only allowed brightness in 10 steps from 0 to 100. Keyboards tend to have less steps, such 3 or 4, and then you end up with it displaying 30%, where it really is 33% leading to unexpected brightness changes when interacting with the applet. However, there has been attempts to fix this [2] but I am not sure whether the dataengine supports that now. The battery applet certainly does not honor these properties yet. (I should look into that, though)

[1] http://quickgit.kde.org/?p=plasma-framework.git&a=blob&h=11013a76f24725cd0b308cd8a2c26ee741fe831b&hb=c2f140fae7c37dad38b6834be7cd8075cd9116cf&f=src%2Fdeclarativeimports%2Fcalendar%2Fqml%2FMonthView.qml#l125

[2] https://git.reviewboard.kde.org/r/119597/

- Kai Uwe Broulik


On Dez. 4, 2014, 8:56 vorm., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121346/
> -----------------------------------------------------------
> 
> (Updated Dez. 4, 2014, 8:56 vorm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> 1. remove redundant "percentage" brightness
> 2. make wheel on tray usable on high precision touchpad: http://qt-project.org/doc/qt-5/qml-qtquick-wheelevent.html#angleDelta-prop
> See also for a bug with similar reason https://bugs.kde.org/show_bug.cgi?id=313579
> 
> 
> Diffs
> -----
> 
>   applets/batterymonitor/package/contents/code/logic.js a5ac7f0 
>   applets/batterymonitor/package/contents/ui/PopupDialog.qml 0298f7f 
>   applets/batterymonitor/package/contents/ui/batterymonitor.qml 5e61a21 
> 
> Diff: https://git.reviewboard.kde.org/r/121346/diff/
> 
> 
> Testing
> -------
> 
> touchpad scrolling now works in a more reasonable adjustion speed.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141204/b4292eeb/attachment.html>