<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121346/">https://git.reviewboard.kde.org/r/121346/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nice!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I will borrow that angleDelta trick for the Plasma calendar where I used a similar, yet different and worse, approach [1].</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The brightness percent value was there for a reason. Powerdevil only allowed brightness in 10 steps from 0 to 100. Keyboards tend to have less steps, such 3 or 4, and then you end up with it displaying 30%, where it really is 33% leading to unexpected brightness changes when interacting with the applet. However, there has been attempts to fix this [2] but I am not sure whether the dataengine supports that now. The battery applet certainly does not honor these properties yet. (I should look into that, though)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] http://quickgit.kde.org/?p=plasma-framework.git&a=blob&h=11013a76f24725cd0b308cd8a2c26ee741fe831b&hb=c2f140fae7c37dad38b6834be7cd8075cd9116cf&f=src%2Fdeclarativeimports%2Fcalendar%2Fqml%2FMonthView.qml#l125</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[2] https://git.reviewboard.kde.org/r/119597/</p></pre>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Dezember 4th, 2014, 8:56 vorm. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Kai Uwe Broulik.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Dez. 4, 2014, 8:56 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">remove redundant "percentage" brightness</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">make wheel on tray usable on high precision touchpad: http://qt-project.org/doc/qt-5/qml-qtquick-wheelevent.html#angleDelta-prop
See also for a bug with similar reason https://bugs.kde.org/show_bug.cgi?id=313579</li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">touchpad scrolling now works in a more reasonable adjustion speed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/batterymonitor/package/contents/code/logic.js <span style="color: grey">(a5ac7f0)</span></li>
<li>applets/batterymonitor/package/contents/ui/PopupDialog.qml <span style="color: grey">(0298f7f)</span></li>
<li>applets/batterymonitor/package/contents/ui/batterymonitor.qml <span style="color: grey">(5e61a21)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121346/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>